lkml.org 
[lkml]   [2011]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: call stop_machine_text_poke() on all CPUs
(2011/10/28 21:30), Rabin Vincent wrote:
> On Fri, Oct 28, 2011 at 11:28:39AM +0900, Masami Hiramatsu wrote:
>> (2011/10/27 16:54), Rabin Vincent wrote:
>>> It appears that stop_machine_text_poke() wants to be called on all CPUs,
>>> like it's done from text_poke_smp(). Fix text_poke_smp_batch() to do
>>> this.
>>
>> cpu_mask==NULL finally falls back to cpu_online_mask, but even though
>> it should be specified correctly.
>
> Not quite. Passing NULL to __stop_machine means that the function will
> be called on any one CPU only, while passing cpu_online_mask means that
> the function will be called on all CPUs. So this patch is a behaviour
> change/bug fix, not just a clarification.

Aah, Right! I just misunderstood.
Then this must be a bugfix!

Thanks!

--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com


\
 
 \ /
  Last update: 2011-11-01 13:07    [W:0.031 / U:0.272 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site