lkml.org 
[lkml]   [2011]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2 v3] udf : enable error print in udf_read_tagged().
    From
    2011/10/9 Joe Perches <joe@perches.com>:
    > On Sun, 2011-10-09 at 13:44 +0900, NamJae Jeon wrote:
    >> 2011/10/9 Joe Perches <joe@perches.com>:
    >> > Not a good patch I think.
    >> > You've broken format strings when they should be coalesced
    >> > and the alignment looks odd.
    >> Would you explain more ? I didn't understand your meaning yet.
    >
    > Format strings are allowed to exceed 80 columns.
    > Arguments should be aligned to the open parenthesis
    >
    > For example:
    >        pr_err("some really long format string longer than "
    >                "80 columns and not broken into pieces, Count: %d\n",
    >                count);
    > is better as:
    >        pr_err("some really long format string longer than 80 columns and not broken into pieces, Count: %d\n",
    >               count);
    >
    > Coalesced format strings makes dmesg output easier to grep.
    > count is not indented by 2 tabs, but 1 tab and 7 spaces.
    >
    > There's no hard and fast rule on the indentation.
    >
    > The patch I sent coalesced all format strings and
    > used that alignment style.
    Clear~ I will do it as your guide.
    Thanks very much. joe~
    >
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-10-09 08:29    [W:0.022 / U:3.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site