Messages in this thread | | | From | Eric Miao <> | Date | Sat, 8 Oct 2011 21:02:19 +0800 | Subject | Re: [PATCH 08/26] ARM: pxa: move z2 to generic cpu_suspend |
| |
On Sat, Oct 8, 2011 at 9:00 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Saturday 08 October 2011 20:37:53 Eric Miao wrote: >> >> >> >> #ifdef CONFIG_PM >> >> +extern void pxa27x_cpu_pm_enter(suspend_state_t state); >> >> + >> >> static void z2_power_off(void) >> >> { >> >> /* We're using deep sleep as poweroff, so clear PSPR to ensure that >> > >> > You really shouldn't have an extern declaration in a .c file. Otherwise >> > looks good to me. >> >> How about this one? > > Yes, looks good as far as I can tell (I still don't quite understand how the > cpu power management all fits together, but I don't see anything wrong with > it either. > > Acked-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |