lkml.org 
[lkml]   [2011]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 08/26] ARM: pxa: move z2 to generic cpu_suspend
    Date
    On Saturday 08 October 2011 20:37:53 Eric Miao wrote:
    > >>
    > >> #ifdef CONFIG_PM
    > >> +extern void pxa27x_cpu_pm_enter(suspend_state_t state);
    > >> +
    > >> static void z2_power_off(void)
    > >> {
    > >> /* We're using deep sleep as poweroff, so clear PSPR to ensure that
    > >
    > > You really shouldn't have an extern declaration in a .c file. Otherwise
    > > looks good to me.
    >
    > How about this one?

    Yes, looks good as far as I can tell (I still don't quite understand how the
    cpu power management all fits together, but I don't see anything wrong with
    it either.

    Acked-by: Arnd Bergmann <arnd@arndb.de>


    \
     
     \ /
      Last update: 2011-10-08 15:03    [W:0.019 / U:29.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site