lkml.org 
[lkml]   [2011]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 22/26] ARM: pxa: only select SMC91x on xcep when networking is enabled
    On Sun, Oct 2, 2011 at 4:03 AM, Arnd Bergmann <arnd@arndb.de> wrote:
    > The smc91x driver is not strictly required for xcep, but it
    > can only be enabled if ethernet support is built into the
    > kernel, so make the dependency more specific.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > ---
    >  arch/arm/mach-pxa/Kconfig |    2 +-
    >  1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
    > index 491c522..ef35ce9 100644
    > --- a/arch/arm/mach-pxa/Kconfig
    > +++ b/arch/arm/mach-pxa/Kconfig
    > @@ -174,7 +174,7 @@ config MACH_XCEP
    >        select MTD_CFI_INTELEXT
    >        select MTD_CFI
    >        select MTD_CHAR
    > -       select SMC91X
    > +       select SMC91X if NET_ETHERNET

    Or let's just remove this 'select SMC91X' completely as it's not
    strictly required?

    BTW - how's the Kconfig cleanup works going? I guess going forward,
    the best way for such cases might be to introduce HAVE_SMC91X, and
    let SMC91X to depend on this? However, that could in turn introduce
    a massive number of HAVE_* for various drivers.

    >        help
    >          PXA255 based Single Board Computer with SMC 91C111 ethernet chip and 64 MB of flash.
    >          Tuned for usage in Libera instruments for particle accelerators.
    > --
    > 1.7.5.4
    >
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-10-08 12:13    [W:0.025 / U:0.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site