Messages in this thread | | | Date | Sat, 8 Oct 2011 17:25:19 -0400 | From | Ted Ts'o <> | Subject | Re: [PATCH 2/2] ext4: MMP: fix error message rate-limiting logic in kmmpd |
| |
On Fri, Sep 30, 2011 at 12:38:20AM +0100, Nikitas Angelinas wrote: > Current logic would print an error message only once, and then > 'failed_writes' would stay at 1. Rework the loop to increment > 'failed_writes' and print the error message every s_mmp_update_interval > * 60 seconds, as intended according to the comment. > > Perhaps it would be better to reset 'failed_writes' to 0 on every > successful write, such that new errors are noticed sooner, but maybe in > the interest of efficiency it would be best not to add an operation on > every kmmpd thread run? > > Signed-off-by: Nikitas Angelinas <nikitas_angelinas@xyratex.com> > Signed-off-by: Andrew Perepechko <andrew_perepechko@xyratex.com> > Acked-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
| |