lkml.org 
[lkml]   [2011]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Subject: [PATCH]
    From
    Date
    On Sat, 2011-10-08 at 19:01 +0100, Jake Burton wrote:
    > diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
    []
    > @@ -279,7 +279,7 @@ static const int ni_irqpin[] =
    >
    > struct ni_private {
    > struct pnp_dev *isapnp_dev;
    > - NI_PRIVATE_COMMON};
    > +NI_PRIVATE_COMMON};

    Hard to believe this is better. Maybe:

    struct ni_private {
    struct pnp_dev *isapnp_dev;
    NI_PRIVATE_COMMON
    };

    It'd be better to inline NI_PRIVATE_COMMON,
    whatever that is. There are 3 uses of that
    really ugly #define.




    \
     
     \ /
      Last update: 2011-10-08 20:25    [W:0.018 / U:122.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site