| Subject | Re: [PATCH 05/26] dynamic_debug: pr_err() call should not depend upon verbosity | From | Joe Perches <> | Date | Fri, 07 Oct 2011 14:21:06 -0700 |
| |
On Fri, 2011-10-07 at 14:33 -0600, jim.cromie@gmail.com wrote: > Also convert to pr_err(), which supplies __func__ via pr_fmt.
Just a note on the changelog. The original code already uses pr_err.
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c [] > @@ -334,8 +334,7 @@ static int ddebug_parse_query(char *words[], int nwords, > query->last_lineno = query->first_lineno; > } > } else { > - if (verbose) > - pr_err("unknown keyword \"%s\"\n", words[i]); > + pr_err("unknown keyword \"%s\"\n", words[i]);
|