lkml.org 
[lkml]   [2011]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/26] dynamic_debug: pr_err() call should not depend upon verbosity
From
Date
On Fri, 2011-10-07 at 14:33 -0600, jim.cromie@gmail.com wrote:
> Also convert to pr_err(), which supplies __func__ via pr_fmt.

Just a note on the changelog.
The original code already uses pr_err.

> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
[]
> @@ -334,8 +334,7 @@ static int ddebug_parse_query(char *words[], int nwords,
> query->last_lineno = query->first_lineno;
> }
> } else {
> - if (verbose)
> - pr_err("unknown keyword \"%s\"\n", words[i]);
> + pr_err("unknown keyword \"%s\"\n", words[i]);




\
 
 \ /
  Last update: 2011-10-07 23:23    [W:0.141 / U:6.932 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site