Messages in this thread | | | Subject | Re: [PATCH v3] omap: dmtimer: convert printk to pr_err | From | Joe Perches <> | Date | Fri, 07 Oct 2011 12:48:21 -0700 |
| |
On Fri, 2011-10-07 at 20:18 +0100, Russell King - ARM Linux wrote: > On Fri, Oct 07, 2011 at 10:40:39AM -0700, Joe Perches wrote: > > At some point in the next couple of years, I want > > to convert all of, or as many as possible of, the > > remaining printk uses to pr_<level>. > If the idea is also to get rid of printk() too (which IMHO would be a > good thing as it kills off the constant need to continually patch for > missing KERN_ prefixes) then that's a good reason (provided Linus > accepts the idea.)
I don't accept that idea yet.
There are about 50K printks vs 20K pr_<level>s in kernel source.
I think 50K lines is _way_ too many to convert in a couple of years.
I think it needs to be done subsystem by subsystem, arch by arch, as maintainers accept.
And there's no hurry.
I have a script that automates most all of the conversions, argument alignments, etc.
| |