lkml.org 
[lkml]   [2011]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] pch_dma: Fix suspend issue
From
Date
On Fri, 2011-10-07 at 19:33 +0900, Tomoya MORINAGA wrote:
> (2011/10/07 15:14), Vinod Koul wrote:
> > This is all is due to not saving nr_channels in probe and using that
> > instead.
> >
> > Looking deeper, struct pch_dma defines array of length MAX_CHAN_NR for
> > channels. Then why do you allocate memory in probe as
> > pd = kzalloc(sizeof(struct pch_dma)+
> > sizeof(struct pch_dma_chan) * nr_channels, GFP_KERNEL);
> > what is the point in allocating additional memory for each channel?
> >
> > Given this, why should there be predefined channel array in pcm_dma?
> >
> > It would be great if we could fix this by dynamically allocating memory
> > for channels based on nr_channels and not wasting due to a static array.
>
> You are right.
> Current pch_dma driver looks like wasting memory.
>
> We must review pch_dma driver again.
Okay, can you update the changelog to indicate how it is fixing the
suspend issue, original change log doesn't help


--
~Vinod



\
 
 \ /
  Last update: 2011-10-07 16:27    [W:0.031 / U:0.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site