[lkml]   [2011]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC PATCH net 2/2] [BUGFIX] bonding: use flush_delayed_work_sync in bond_close
    On Fri, Oct 7, 2011 at 8:50 PM, Mitsuo Hayasaka
    <> wrote:
    > The bond_close() calls cancel_delayed_work() to cancel delayed works.
    > It, however, cannot cancel works that were already queued in workqueue.
    > The bond_open() initializes work->data, and proccess_one_work() refers
    > get_work_cwq(work)->wq->flags. The get_work_cwq() returns NULL when
    > work->data has been initialized. Thus, a panic occurs.
    > This patch uses flush_delayed_work_sync() instead of cancel_delayed_work()
    > in bond_close(). It cancels delayed timer and waits for work to finish
    > execution. So, it can avoid the null pointer dereference due to the
    > parallel executions of proccess_one_work() and initializing proccess
    > of bond_open().
    > Signed-off-by: Mitsuo Hayasaka <>
    > Cc: Jay Vosburgh <>
    > Cc: Andy Gospodarek <>

    Makes sense,

    Reviewed-by: WANG Cong <>


     \ /
      Last update: 2011-10-07 15:37    [W:0.048 / U:6.788 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site