lkml.org 
[lkml]   [2011]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch] dma/timberdale: free_irq() on an error path
    From
    Date
    On Fri, 2011-09-23 at 09:16 +0300, Dan Carpenter wrote:
    > There was an error path that skipped the free_irq() step by mistake.
    >
    > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    >
    > diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c
    > index 6dbdf45..a4a398f 100644
    > --- a/drivers/dma/timb_dma.c
    > +++ b/drivers/dma/timb_dma.c
    > @@ -762,7 +762,7 @@ static int __devinit td_probe(struct platform_device *pdev)
    > if ((i % 2) == pchan->rx) {
    > dev_err(&pdev->dev, "Wrong channel configuration\n");
    > err = -EINVAL;
    > - goto err_tasklet_kill;
    > + goto err_free_irq;
    > }
    >
    > td_chan->chan.device = &td->dma;
    Applied thanks

    --
    ~Vinod



    \
     
     \ /
      Last update: 2011-10-07 07:09    [W:0.023 / U:61.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site