[lkml]   [2011]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [BUGFIX][PATCH] Freezer, CPU hotplug, x86 Microcode: Fix task freezing failures
    On Thu, Oct 06, 2011 at 02:50:46AM -0400, Srivatsa S. Bhat wrote:
    > On 10/06/2011 04:13 AM, Rafael J. Wysocki wrote:
    > > On Wednesday, October 05, 2011, Srivatsa S. Bhat wrote:
    > >> On 10/06/2011 01:56 AM, Rafael J. Wysocki wrote:
    > >>>
    > >>> OK, can you please repost the patch with Borislav's Acked-by and Tested-by
    > >>> and add some more Intel people to the CC list?
    > >>>
    > >>
    > >> Sure, I'll do that. Thank you.
    > >> But are we not going to consider a cleaner/correct solution such as the
    > >> one proposed here:
    > >>
    > >>
    > >> Well, honestly I don't mean to be stubborn, but somehow, knowing that
    > >> there are issues with my patch doesn't make me feel very comfortable
    > >> going with it, especially when there is another approach, which I
    > >> believe can fix the issue properly, without undesirable side-effects.
    > >>
    > >> I agree that the issues are mostly some corner cases, so if you want a
    > >> quick fix for now, I guess we can go with this patch and then later on
    > >> follow-up with a proper solution to this whole problem.
    > >
    > > It ultimately is your call. If you feel more comfortable with the
    > > alternative, just post that one instead.
    > >
    > Cool! I am working on implementing that other solution. I'll post it as soon
    > as I am done writing and testing that patch.

    Please test your other patch which removes the CPU_DEAD line from the
    microcode CPU hotplug callback on an Intel box with microcode too and
    submit it. This fix makes sense irrespective of a suspend/resume fix
    because reloading the ucode when onlining the CPU is clearly unneeded.



    Advanced Micro Devices GmbH
    Einsteinring 24, 85609 Dornach
    GM: Alberto Bozzo
    Reg: Dornach, Landkreis Muenchen
    HRB Nr. 43632 WEEE Registernr: 129 19551

     \ /
      Last update: 2011-10-06 10:37    [W:0.023 / U:43.388 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site