Messages in this thread | | | Date | Thu, 06 Oct 2011 20:18:00 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: Removed superfluous parentheses in macro defs |
| |
On 10/06/2011 03:22 PM, Alex Ben wrote: > 1) make it consistent with other constant macro deinitions, which > don't have parentheses, as they are really superfluous.
Superfluous, yes, but it makes the expression read more regular.
> diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h > index 5e64171..92621c1 100644 > --- a/arch/x86/include/asm/segment.h > +++ b/arch/x86/include/asm/segment.h > @@ -10,7 +10,7 @@ > (((flags) & _AC(0x0000f0ff,ULL)) << 40) | \ > (((limit) & _AC(0x000f0000,ULL)) << (48-16)) | \ > (((base) & _AC(0x00ffffff,ULL)) << 16) | \ > - (((limit) & _AC(0x0000ffff,ULL)))) > + ((limit) & _AC(0x0000ffff,ULL))) >
So NAK.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |