lkml.org 
[lkml]   [2011]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2 v3] udf : enable error print in udf_read_tagged().
On Wed 05-10-11 15:19:58, Joe Perches wrote:
> On Thu, 2011-10-06 at 00:08 +0200, Jan Kara wrote:
> > Hello,
> >
> > On Mon 03-10-11 22:53:57, Namjae Jeon wrote:
> > > While reading metadata, if a problem occurs, Print out only one of the
> > > five case.(It also does not show a checksum properly.) Because currently
> > > it have been disable by undef udf_debug. If there is a problem with
> > > scratched disc or loader, the user needs to know which error happened.
> > > And I use pr_fmt instead of printk by joe's suggestion. I try to modify
> > > totally it to pr_fmt also.
>
> > Thanks for the patch. I'm willing to take the patch since it's an
> > improvement but what would be even nicer is to have error reporting like in
> > ext3 / ext4. We would have functions udf_info, udf_warn, udf_err which
> > also print sb->s_id with each error so that user can better identify on
> > which filesystem error happened.
>
> Modifying the follow-on patch I sent would be pretty trivial.
Sure, I can do that but if Namjae is willing to do it, I'd have less work
:).

Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2011-10-06 23:45    [W:0.069 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site