Messages in this thread | | | Date | Thu, 6 Oct 2011 14:22:11 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 01/10] ASoC: wm8510: Convert to snd_soc_cache_sync |
| |
On Thu, Oct 06, 2011 at 02:11:43PM +0800, Axel Lin wrote:
> +static int wm8510_volatile_register(struct snd_soc_codec *codec, > + unsigned int reg) > +{ > + switch (reg) { > + case WM8510_RESET: > + return 1; > + default: > + return 0; > + } > +} > +
This is wrong in quite a few of the patches - all the 7, 9 CODECs are write only, there's no readback support at all (in general if the driver isn't actully verifying a device ID or otherwise doing a physical read then it probably doesn't support readback).
| |