Messages in this thread | | | From | Axel Lin <> | Date | Thu, 6 Oct 2011 19:33:29 +0800 | Subject | Re: [PATCH 06/10] ASoC: wm8940: Convert to snd_soc_cache_sync |
| |
>> +static int wm8940_volatile_register(struct snd_soc_codec *codec, >> + unsigned int reg) >> +{ >> + switch (reg) { >> + case WM8940_SOFTRESET: >> + return 1; >> + default: >> + return 0; >> + } >> +} > I guess this makes sense from point of view of keeping things inline with > more complex drivers. Otherwise I'd expect to see something like: > { > return !!(reg == WM894_SOFTRESET); > }
Either is ok to me. But current syntax makes it easier to add more registers to be volatile if necessary.
So I'll let Mark decide if I need to send a v2 for changing this.
Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |