lkml.org 
[lkml]   [2011]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name
From
Date
On Mon, 2011-10-03 at 17:06 +0100, Peter Zijlstra wrote:
> On Mon, 2011-10-03 at 13:01 +0100, Ian Campbell wrote:
> > Noticed this while poking around. Seems like the code was lifted a bit
> > more thoroughly from the migration thread mgmt code than the author of
> > the preceding comment intended...
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > --- a/kernel/stop_machine.c
> > +++ b/kernel/stop_machine.c
> > @@ -312,7 +312,7 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
> > p = kthread_create_on_node(cpu_stopper_thread,
> > stopper,
> > cpu_to_node(cpu),
> > - "migration/%d", cpu);
> > + "stopper/%d", cpu);
> > if (IS_ERR(p))
> > return notifier_from_errno(PTR_ERR(p));
> > get_task_struct(p);
> >
>
> IIRC it was because userspace already knew about the migration thread
> and we didn't want to confuse things further. But yeah, its not
> particularly important.

I'm not sure what knowledge userspace has of either kernel thread but
fair enough, patch withdrawn.

Ian.



\
 
 \ /
  Last update: 2011-10-05 08:07    [W:2.924 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site