Messages in this thread | | | Date | Wed, 5 Oct 2011 16:38:04 +0200 (CEST) | From | Lukas Czerner <> | Subject | Re: [PATCH v6] fat: Batched discard support for fat |
| |
On Thu, 1 Sep 2011, OGAWA Hirofumi wrote:
> Kyungmin Park <kmpark@infradead.org> writes: > > > Hi Ogawa, > > Hi, > > > Do you still object to merge batched discard support on fat? > > > > If the current batched discard concept doesn't changed, it can't merge it? > > I'm not blaming "concept". I'm saying current implements (and due to > current interface confusion) is confusing and makes userland hard to use it. > > I really think I explained all my concerns and current implement > confusion. > > Last time I checked, those implementations had even the different error > code at EOF. How can I say your implement will work without knowing > right implement? > > Again, it is reason, and I'm not blaming "concept" or your implement > itself. > > Thanks.
Please see test #260 in xfstests, which was recently added to check for common mistakes in FITRIM argument handling.
Thanks! -Lukas
| |