lkml.org 
[lkml]   [2011]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ext3/balloc.c: local functions should be static
On Fri 23-09-11 13:55:52, H Hartley Sweeten wrote:
> This quites the sparse noise:
>
> warning: symbol 'ext3_trim_all_free' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Thanks, merged into my tree.

Honza
>
> ---
>
> diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
> index 6386d76..8e62ec5 100644
> --- a/fs/ext3/balloc.c
> +++ b/fs/ext3/balloc.c
> @@ -1924,9 +1924,10 @@ unsigned long ext3_bg_num_gdb(struct super_block *sb, int group)
> * reaches any used block. Then issue a TRIM command on this extent and free
> * the extent in the block bitmap. This is done until whole group is scanned.
> */
> -ext3_grpblk_t ext3_trim_all_free(struct super_block *sb, unsigned int group,
> - ext3_grpblk_t start, ext3_grpblk_t max,
> - ext3_grpblk_t minblocks)
> +static ext3_grpblk_t ext3_trim_all_free(struct super_block *sb,
> + unsigned int group,
> + ext3_grpblk_t start, ext3_grpblk_t max,
> + ext3_grpblk_t minblocks)
> {
> handle_t *handle;
> ext3_grpblk_t next, free_blocks, bit, freed, count = 0;
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2011-10-05 01:33    [from the cache]
©2003-2011 Jasper Spaans