lkml.org 
[lkml]   [2011]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFCv3][PATCH 1/4] replace string_get_size() arrays
From
Date
On Tue, 2011-10-04 at 13:42 -0700, Joe Perches wrote:
> > Right, but we're only handling u64.
>
> So the declaration should be:
>
> static const char byte_units[] = " KMGTPE";

I guess that's worth a comment. But that first character doesn't get
used. There were two alternatives:

static const char byte_units[] = "_KMGTPE";

or something along the lines of:

+ static const char byte_units[] = "KMGTPE";
...
+ index--;
+ /* index=-1 is plain 'B' with no other unit */
+ if (index >= 0) {

We don't ever _actually_ look at the space (or underscore). I figured
the _ was nicer since it would be _obvious_ if it ever got printed out
somehow.

-- Dave



\
 
 \ /
  Last update: 2011-10-04 22:55    [W:0.028 / U:79.636 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site