Messages in this thread | | | Date | Tue, 4 Oct 2011 07:59:53 +0100 | From | Herbert Xu <> | Subject | Re: [PATCH v4] crc32c: Implement CRC32c with slicing-by-8 algorithm |
| |
On Mon, Oct 03, 2011 at 05:55:10PM -0700, Darrick J. Wong wrote: > > So what I think I'm hearing is... > > 1. Apply Bob's slice-by-8 algorithm patch to regular crc32. > 2. Adapt crc32's build code to generate crc32c as well. > 3. Remove crypto/crc32c.c's implementation and have it wrap the code generated > by #2. > 4. Retain the current libcrc32c. I guess if you don't configure CRYPTO and > CRYPTO_CRC32C then it could also just reference the generated crc32c functions > directly. > > Is this a satisfactory way to move forward?
All good except that you don't really have to touch libcrc32c at all.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |