[lkml]   [2011]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC][PATCH] ASoC: Avoid writing to WM8971_RESET in wm8971_resume
    On Tue, Oct 04, 2011 at 07:44:22AM +0800, Axel Lin wrote:

    > While reading the code, I don't understand why we need to do (in wm8971_resume):
    > for (i = 0; i < ARRAY_SIZE(wm8971_reg); i++) {
    > if (i + 1 == WM8971_RESET)
    > continue;
    > My understanding is that we want to avoid writing to WM8971_RESET on resume.

    Yeah, this looks like a leftover from some older code which omitted
    register zero from the cache for some small memory savings. Now things
    are using the standard cache code rather than custom cache code this
    is buggy.

    Applied, thanks.

     \ /
      Last update: 2011-10-04 17:07    [W:0.018 / U:130.256 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site