lkml.org 
[lkml]   [2011]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] tracing: fix event_subsystem ref counting
    From
    Date
    On Tue, 2011-11-01 at 09:12 +0800, Li Zefan wrote:
    > Steven Rostedt wrote:
    > > On Mon, 2011-10-31 at 11:07 +0200, Ilya Dryomov wrote:
    > >> Fix a bug introduced by e9dbfae5, which prevents event_subsystem from
    > >> ever being released.
    > >>
    > >> Ref_count was added to keep track of subsystem users, not for counting
    > >> events. Subsystem is created with ref_count = 1, so there is no need to
    > >> increment it for every event, we have nr_events for that. Fix this by
    > >> touching ref_count only when we actually have a new user -
    > >> subsystem_open().
    > >
    > > Good catch, I'll pull this in.
    > >
    >
    > I made a different fix last week:
    >
    > http://marc.info/?l=linux-kernel&m=131978486911595&w=2
    >
    > but I guess Ilya's version is a bit better.

    That patch was still in my queue to process, as I missed it during my
    travels to Prague. But yeah, I think Ilya's patch is a better solution.

    Thanks!

    -- Steve





    \
     
     \ /
      Last update: 2011-11-01 02:41    [W:0.032 / U:62.376 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site