Messages in this thread | | | Date | Tue, 01 Nov 2011 09:12:12 +0800 | From | Li Zefan <> | Subject | Re: [PATCH] tracing: fix event_subsystem ref counting |
| |
Steven Rostedt wrote: > On Mon, 2011-10-31 at 11:07 +0200, Ilya Dryomov wrote: >> Fix a bug introduced by e9dbfae5, which prevents event_subsystem from >> ever being released. >> >> Ref_count was added to keep track of subsystem users, not for counting >> events. Subsystem is created with ref_count = 1, so there is no need to >> increment it for every event, we have nr_events for that. Fix this by >> touching ref_count only when we actually have a new user - >> subsystem_open(). > > Good catch, I'll pull this in. >
I made a different fix last week:
http://marc.info/?l=linux-kernel&m=131978486911595&w=2
but I guess Ilya's version is a bit better.
| |