lkml.org 
[lkml]   [2011]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/1] Staging: hv: Move the mouse driver out of staging
Date


> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Saturday, October 29, 2011 2:33 AM
> To: Jesper Juhl
> Cc: KY Srinivasan; dmitry.torokhov@gmail.com; jkosina@suse.cz;
> gregkh@suse.de; ohering@suse.com; linux-kernel@vger.kernel.org;
> virtualization@lists.osdl.org; joe@perches.com; devel@linuxdriverproject.org
> Subject: Re: [PATCH 1/1] Staging: hv: Move the mouse driver out of staging
>
> On Sat, Oct 29, 2011 at 12:54:34AM +0200, Jesper Juhl wrote:
> > > + default:
> > > + pr_err("unhandled packet type %d, tid %llx len
> %d\n",
> > > + desc->type,
> > > + req_id,
> > > + bytes_recvd);
> >
> > Why not:
> >
> > pr_err("unhandled packet type %d, tid %llx
> > len %d\n", desc->type, req_id, bytes_recvd);
>
> Because then the printk would be messed up? Your final printed
> string would look like:
>
> "unhandled packet type %d, tid %llx
> len %d\n"
>
> Don't break strings up across lines because it breaks grep. If K. Y.
> wants to put all the parameters on one line instead of three that
> would probably be better, but in the end who cares?
>
Thanks Dan.

Regards,

K. Y




\
 
 \ /
  Last update: 2011-10-30 17:19    [W:0.054 / U:4.512 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site