lkml.org 
[lkml]   [2011]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/9] Staging: comedi: fix printk issue in cb_pcidas.c
On 30/09/11 23:18, Ravishankar Karkala Mallikarjunayya wrote:

> This is a patch to the cb_pcidas.c file that fixes up a printk warning found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
> ---
> drivers/staging/comedi/drivers/cb_pcidas.c | 21 +++++++++++++--------
> 1 files changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/comedi/drivers/cb_pcidas.c
> index 9dec153..9d16c6c 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas.c
> @@ -565,7 +565,8 @@ static int cb_pcidas_attach(struct comedi_device *dev,
> int index;
> int i;
>
> - pr_info("comedi%d: cb_pcidas: ", dev->minor);
> + dev_info(&pcidev->dev, "comedi%d: cb_pcidas:\n",
> + dev->minor);

This printk can probably be removed now. It's just noise. Similar in
other places too.

~Ryan


\
 
 \ /
  Last update: 2011-10-04 01:33    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean