lkml.org 
[lkml]   [2011]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRE: [PATCH v2] binfmt_elf: Fix PIE execution with randomization disabled (was Re: [RFC PATCH] binfmt_elf: Fix PIE execution with randomization disabled)
    On Mon, 3 Oct 2011, Lu, Hongjiu wrote:

    > Why not
    >
    > #if defined(CONFIG_X86) || defined(CONFIG_ARM)
    > #define CHECK_PF_RANDOMIZE 1
    > #else
    > #define CHECK_PF_RANDOMIZE 0
    > #endif
    > if (CHECK_PF_RANDOMIZE && (current->flags & PF_RANDOMIZE))
    > load_bias = 0;
    > else
    > load_bias = ELF_PAGESTART(ELF_ET_DYN_BASE - vaddr);

    If anything, that is not particularly good name for that macro (as we are
    checking current->flags for PF_RANDOMIZE at other places indepenedntly on
    this).

    Personally, I find my original patch the most readable one, but I don't
    care much, it's really bike-shedding.

    --
    Jiri Kosina
    SUSE Labs


    \
     
     \ /
      Last update: 2011-10-03 23:17    [W:0.020 / U:32.380 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site