lkml.org 
[lkml]   [2011]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH 2/6] ASoC: codecs: AK4641 depends on GPIOLIB
On Mon, Oct 03, 2011 at 06:19:48PM +0200, Arnd Bergmann wrote:

> When the GPIO API is stubbed out, the definition of struct gpio
> is empty, so you cannot access the members, which seems to be
> intentional behavior.

That doesn't seem terribly helpful, it means drivers either need to
ifdef or not use the bulk functions.

> struct device;
> -struct gpio;
> +struct gpio {
> + unsigned gpio;
> + unsigned long flags;
> + const char *label;
> +};

This looks much more sensible to me.

> select SND_SOC_WL1273 if MFD_WL1273_CORE
> - select SND_SOC_WM1250_EV1 if I2C
> + select SND_SOC_WM1250_EV1 if I2C && GENERIC_GPIO

Or ifdefs in the driver.


\
 
 \ /
  Last update: 2011-10-03 18:37    [W:0.529 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site