Messages in this thread | | | Date | Mon, 3 Oct 2011 17:34:41 +0100 | From | Mark Brown <> | Subject | Re: [alsa-devel] [PATCH 2/6] ASoC: codecs: AK4641 depends on GPIOLIB |
| |
On Mon, Oct 03, 2011 at 06:19:48PM +0200, Arnd Bergmann wrote:
> When the GPIO API is stubbed out, the definition of struct gpio > is empty, so you cannot access the members, which seems to be > intentional behavior.
That doesn't seem terribly helpful, it means drivers either need to ifdef or not use the bulk functions.
> struct device; > -struct gpio; > +struct gpio { > + unsigned gpio; > + unsigned long flags; > + const char *label; > +};
This looks much more sensible to me.
> select SND_SOC_WL1273 if MFD_WL1273_CORE > - select SND_SOC_WM1250_EV1 if I2C > + select SND_SOC_WM1250_EV1 if I2C && GENERIC_GPIO
Or ifdefs in the driver.
| |