lkml.org 
[lkml]   [2011]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRE: [PATCH v2 0/3] staging: zcache: xcfmalloc support
    From
    Date
    Hi Dan/Nitin,

    I've been reading through Seth's patches a bit and looking over the
    locking in general. I'm wondering why preempt_disable() is used so
    heavily. Preempt seems to be disabled for virtually all of zcache's
    operations. It seems a bit unorthodox, and I guess I'm anticipating the
    future screams of the low-latency folks. :)

    I think long-term it will hurt zcache's ability to move in to other
    code. Right now, it's pretty limited to being used in conjunction with
    memory reclaim called from kswapd. Seems like something we ought to add
    to the TODO list before it escapes from staging/.

    -- Dave



    \
     
     \ /
      Last update: 2011-10-03 18:05    [W:7.690 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site