lkml.org 
[lkml]   [2011]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2 v2] udf : enable error print in udf_read_tagged().
    From
    2011/10/3 Joe Perches <joe@perches.com>:
    > On Mon, 2011-10-03 at 16:19 +0900, Namjae Jeon wrote:
    >> And I use pr_fmt instead of printk by joe's suggestion. I try to modify totally it to pr_fmt also.
    > []
    >> diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
    > []
    >> @@ -19,18 +21,15 @@
    >>  #undef UDFFS_DEBUG
    >>
    >>  #ifdef UDFFS_DEBUG
    >> -#define udf_debug(f, a...) \
    >> -do { \
    >> -     printk(KERN_DEBUG "UDF-fs DEBUG %s:%d:%s: ", \
    >> -             __FILE__, __LINE__, __func__); \
    >> -     printk(f, ##a); \
    >> -} while (0)
    >> +#define udf_debug(fmt, ...)  \
    >> +     pr_debug("DEBUG %s:%d:%s: ", fmt,       \
    >> +             __FILE__, __LINE__, __func__, __VA_ARGS__);
    >
    > This doesn't compile properly if UDFFS_DEBUG is
    > #defined.
    >
    > No comma should be between "DEBUG %s:%d:%s: " and fmt.
    Hi. Joe.
    oops! it's my mistake.
    I sent v3 patch again.
    Would you review one more ?
    Thanks.
    >
    >
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-10-03 16:01    [W:0.022 / U:0.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site