lkml.org 
[lkml]   [2011]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: One comment on the __release_region in kernel/resource.c
    From
    On Mon, Oct 3, 2011 at 12:24, KAMEZAWA Hiroyuki
    <kamezawa.hiroyu@jp.fujitsu.com> wrote:
    > On Sun, 2 Oct 2011 21:57:07 +0800
    > Wei Yang <weiyang.kernel@gmail.com> wrote:
    >
    >> Dear experts,
    >>
    >> I am viewing the source code of __release_region() in kernel/resource.c.
    >> And I have one comment for the performance issue.
    >>
    >> For example, we have a resource tree like this.
    >> 10-89
    >>    20-79
    >>        30-49
    >>        55-59
    >>        60-64
    >>        65-69
    >>    80-89
    >> 100-279
    >>
    >> If the caller wants to release a region of [50,59], the original code will
    ^^^^^^^
    Do you really mean [50,59]?
    I don't think that's allowed, as the tree has [55,59], so you would release a
    larger region that allocated.

    Gr{oetje,eeting}s,

                            Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
                                    -- Linus Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-10-03 13:17    [W:2.330 / U:0.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site