lkml.org 
[lkml]   [2011]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] UART: add CSR SiRFprimaII SoC on-chip uart drivers
    2011/10/28 Baruch Siach <baruch@tkos.co.il>:
    > Hi Barry,
    >
    > On Thu, Oct 27, 2011 at 08:27:33PM -0700, Barry Song wrote:
    >> From: Rong Wang <Rong.Wang@csr.com>
    >>
    >> SiRFprimaII is the latest generation application processor from CSR’s
    >> multi-function SoC product family.
    >> The SoC support codes are in arch/arm/mach-prima2 from Linux mainline
    >> 3.0.
    >>
    >> There are three dedicated UARTs in system. This patch adds basic driver
    >> support for them.
    >>
    >> It has used the newest pinmux subsystem from Linus Walleij.
    >>
    >> Cc: Linus Walleij <linus.walleij@linaro.org>
    >> Signed-off-by: Rong Wang <Rong.Wang@csr.com>
    >> Signed-off-by: Bin Shi <Bin.Shi@csr.com>
    >> Signed-off-by: Barry Song <Baohua.Song@csr.com>
    >> Acked-by: Alan Cox <alan@linux.intel.com>
    >> ---
    >
    > [snip]
    >
    >> +config SERIAL_SIRFSOC
    >> +        tristate "SiRF SoC Platform Serial port support"
    >> +        depends on ARM && ARCH_PRIMA2
    >> +        select SERIAL_CORE
    >> +        help
    >> +          Support for the on-chip UART on the CSR SiRFprimaII series,
    >> +          providing /dev/ttyS0, 1 and 2 (note, some machines may not
    >> +          provide all of these ports, depending on how the serial port
    >> +          pins are configured.
    >
    > Unbalanced parentheses.

    Hi Baruch,
    Thanks for reviewing! I sent this mail for Torvalds to pick seperately
    since it depends on pinctl tree, and it was not gone through tty tree
    since tty has no pinctrl before linus merges it.
    This patch has been reviewed and acked in linux-serial, unfortunately,
    missed this error.
    i am not sure whether i will make Linus confused if i send a new
    version at this moment. how about i send a seperate patch to fix this
    after the driver is applied?

    >
    > baruch
    >
    > --
    >                                                     ~. .~   Tk Open Systems
    > =}------------------------------------------------ooO--U--Ooo------------{=
    >   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

    -barry
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-10-28 09:37    [W:2.462 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site