lkml.org 
[lkml]   [2011]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ida: make ida_simple_get/put() IRQ safe
On Fri, 28 Oct 2011 16:11:49 -0700
Tejun Heo <tj@kernel.org> wrote:

> On Fri, Oct 28, 2011 at 04:01:15PM -0700, Andrew Morton wrote:
> > On Wed, 26 Oct 2011 13:33:11 -0700
> > Tejun Heo <tj@kernel.org> wrote:
> >
> > > It's often convenient to be able to release resource from IRQ context.
> > > Make ida_simple_*() use irqsave/restore spin ops so that they are IRQ
> > > safe.
> >
> > The patch also accidentally makes ida_simple_get() callable from
> > interrupt context. That's a somewhat unreliable operation due to
> > -ENOMEM possibilities even with GFP_ATOMIC.
>
> Hmmm... We can add a WARN_ON_ONCE() there but do we really care? If
> the caller is using GFP_ATOMIC, it should be expecting unreliability.
>

No, I don't think we care - I was just chin-scratching and augmenting
some deficient changeloggery. Also, showing that I'd actually read the
thing ;)




\
 
 \ /
  Last update: 2011-10-29 01:23    [W:0.043 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site