lkml.org 
[lkml]   [2011]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -v2 07/16] PCI: TILE: convert pcibios_set_master() to a non-inlined function
    Date
    From: Myron Stowe <mstowe@redhat.com>

    This patch converts TILE's architecture-specific 'pcibios_set_master()'
    routine to a non-inlined function. This will allow follow on patches
    to create a generic 'pcibios_set_master()' function using the '__weak'
    attribute which can be used by all architectures as a default which,
    if necessary, can then be over-ridden by architecture-specific code.

    Converting 'pci_bios_set_master()' to a non-inlined function will
    allow TILE's 'pcibios_set_master()' implementation to remain
    architecture-specific after the generic version is introduced and
    thus, not change current behavior.

    No functional change.

    Signed-off-by: Myron Stowe <myron.stowe@redhat.com>
    ---

    arch/tile/include/asm/pci.h | 7 -------
    arch/tile/kernel/pci.c | 5 +++++
    2 files changed, 5 insertions(+), 7 deletions(-)

    diff --git a/arch/tile/include/asm/pci.h b/arch/tile/include/asm/pci.h
    index 7f03cef..2a2abc7 100644
    --- a/arch/tile/include/asm/pci.h
    +++ b/arch/tile/include/asm/pci.h
    @@ -76,13 +76,6 @@ static inline int pcibios_assign_all_busses(void)
    return 1;
    }

    -/*
    - * No special bus mastering setup handling.
    - */
    -static inline void pcibios_set_master(struct pci_dev *dev)
    -{
    -}
    -
    #define PCIBIOS_MIN_MEM 0
    #define PCIBIOS_MIN_IO 0

    diff --git a/arch/tile/kernel/pci.c b/arch/tile/kernel/pci.c
    index 2a8014c..08b8943 100644
    --- a/arch/tile/kernel/pci.c
    +++ b/arch/tile/kernel/pci.c
    @@ -394,6 +394,11 @@ void __devinit pcibios_fixup_bus(struct pci_bus *bus)
    /* Nothing needs to be done. */
    }

    +void pcibios_set_master(struct pci_dev *dev)
    +{
    + /* No special bus mastering setup handling. */
    +}
    +
    /*
    * This can be called from the generic PCI layer, but doesn't need to
    * do anything.


    \
     
     \ /
      Last update: 2011-10-28 23:51    [W:5.116 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site