lkml.org 
[lkml]   [2011]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] coredump: wait on the core pattern umh at least once
Date
If a thread crashes as a result of a signal on the thread group leader
that signal can still be pending, which means the loop in
wait_for_dump_helpers() falls straight though.

This can mean that the crashing process is reaped before any core
pattern user-mode helper is run, leaving it without entries in /proc
to look through.

While the helper obviously has to deal with that, tweaking this loop
so it runs at least one iteration even in that case helps a lot.

Signed-off-by: Scott James Remnant <scott@netsplit.com>
---
fs/exec.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/exec.c b/fs/exec.c
index 25dcbe5..8959d304 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -2030,11 +2030,11 @@ static void wait_for_dump_helpers(struct file *file)
pipe->readers++;
pipe->writers--;

- while ((pipe->readers > 1) && (!signal_pending(current))) {
+ do {
wake_up_interruptible_sync(&pipe->wait);
kill_fasync(&pipe->fasync_readers, SIGIO, POLL_IN);
pipe_wait(pipe);
- }
+ } while ((pipe->readers > 1) && (!signal_pending(current)));

pipe->readers--;
pipe->writers++;
--
1.7.3.1


\
 
 \ /
  Last update: 2011-10-28 22:13    [W:0.058 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site