lkml.org 
[lkml]   [2011]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/13] vfs: fs_may_remount_ro: turn unnecessary check into a WARN_ON
    Date
    From: Miklos Szeredi <mszeredi@suse.cz>

    Now a successful sb_prepare_remount_readonly() should ensure that no
    writable files remain for this superblock. So turn this check into a
    WARN_ON.

    Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
    Tested-by: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
    ---
    fs/file_table.c | 7 +++++--
    1 files changed, 5 insertions(+), 2 deletions(-)

    diff --git a/fs/file_table.c b/fs/file_table.c
    index c322794..dc9f437 100644
    --- a/fs/file_table.c
    +++ b/fs/file_table.c
    @@ -486,8 +486,11 @@ int fs_may_remount_ro(struct super_block *sb)
    if (inode->i_nlink == 0)
    goto too_bad;

    - /* Writeable file? */
    - if (S_ISREG(inode->i_mode) && (file->f_mode & FMODE_WRITE))
    + /*
    + * Writable file?
    + * Should be caught by sb_prepare_remount_readonly().
    + */
    + if (WARN_ON(S_ISREG(inode->i_mode) && (file->f_mode & FMODE_WRITE)))
    goto too_bad;
    } while_file_list_for_each_entry;
    lg_global_unlock(files_lglock);
    --
    1.7.3.4


    \
     
     \ /
      Last update: 2011-10-28 14:17    [W:2.967 / U:0.764 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site