lkml.org 
[lkml]   [2011]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4] dmaengine: add CSR SiRFprimaII DMAC driver
    From
    Date
    On Thu, 2011-10-27 at 09:33 +0100, Russell King - ARM Linux wrote:
    > On Thu, Oct 27, 2011 at 01:48:55PM +0530, Vinod Koul wrote:
    > > On Mon, 2011-10-17 at 20:08 -0700, Barry Song wrote:
    > > > From: Rongjun Ying <Rongjun.Ying@csr.com>
    > > >
    > > > Cc: Jassi Brar <jaswinder.singh@linaro.org>
    > > > Cc: Arnd Bergmann <arnd@arndb.de>
    > > > Cc: Linus Walleij <linus.walleij@linaro.org>
    > > > Signed-off-by: Rongjun Ying <rongjun.ying@csr.com>
    > > > Signed-off-by: Barry Song <Baohua.Song@csr.com>
    > > > ---
    > > > -v4:
    > > > add error handler in probe;
    > > > free resource in remove;
    > > > add necessary comments in source codes;
    > > > fix the mismatch of license between file head and MODULE_LINCENSE;
    > > > define MACRO to replace magic number for xlen/dma_width boundary.
    > > Barry,
    > >
    > > You should _always_ run checkpatch before sending patches. It should
    > > have 0 errors.
    >
    > Not true.
    >
    > > ERROR: trailing whitespace
    > > #773: FILE: drivers/dma/sirf-dma.c:649:
    > > +^I$
    > >
    > >
    > > Also there are bunch of 80char warning, see if you can reduce/eliminate
    > > them without sacrificing the code readability, and looking at them it
    > > seems possible
    >
    > 80char warnings about printks should be ignored, because breaking kernel
    > messages across lines prevents them from being greppable. This (breaking
    > kernel messages, particularly error messages, across multiple lines) is a
    > topic Linus has frequently complained about.
    Sure, I wasn't complaining about printks, btw none of them were hit by
    printks.

    These were mostly write_l exceeding 80chars, thats why my suggestion to
    see if they can be reduced/eliminated without sacrificing code
    readability


    --
    ~Vinod



    \
     
     \ /
      Last update: 2011-10-27 10:43    [W:0.024 / U:29.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site