Messages in this thread | | | Date | Thu, 27 Oct 2011 10:40:30 +0200 | Subject | Re: drivers/net/ethernet/apple | From | Geert Uytterhoeven <> |
| |
On Thu, Oct 27, 2011 at 09:45, Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote: > On Wed, 2011-10-26 at 22:16 -0700, Geert Uytterhoeven wrote: >> On Tue, Oct 25, 2011 at 22:19, Geert Uytterhoeven >> <geert@linux-m68k.org> wrote: >> > drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal >> Semiconductor >> > (Now Cirrus Logic) CS89[02]0, so it belongs in >> drivers/net/ethernet/cirrus, >> > next to cs89x0.c. >> >> And on the first -next run since its inclusion: >> >> | drivers/net/ethernet/apple/mac89x0.c:107:20: error: cs89x0.h: No >> such file or directory >> >> it needs the (shared) header file which is in >> drivers/net/ethernet/cirrus/. >> >> http://kisskb.ellerman.id.au/kisskb/buildresult/4835488/ > > Ah, yeah, now it is coming back to me why I placed cs89x0.[ch] in the > drivers/net/ethernet/apple/ because it was grouped with the "common" > drivers. The intent was to group drivers that use common code together. > > I can put together a patch to fix this if you are not able to.
I will create a patch to move mac89x0 to .../cirrus, when I get to compiling a Mac kernel myself.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |