lkml.org 
[lkml]   [2011]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] ata port runtime pm
On 10/27/2011 11:21 PM, Lin Ming wrote:
> @@ -3208,6 +3209,11 @@ int ata_scsi_queuecmd(struct Scsi_Host *shost, struct scsi_cmnd *cmd)
>
> ap = ata_shost_to_port(shost);
>
> + if (pm_runtime_suspended(&ap->tdev))
> + pm_runtime_resume(&ap->tdev);
> + pm_runtime_mark_last_busy(&ap->tdev);
> + pm_request_autosuspend(&ap->tdev);
> +
> spin_lock_irqsave(ap->lock, irq_flags);
>


Putting this into the core command dispatch fast-path is rather
disappointing. That's at least one additional lock, plus some atomic
instructions and tests.

Jeff




\
 
 \ /
  Last update: 2011-10-28 05:41    [from the cache]
©2003-2011 Jasper Spaans