Messages in this thread | | | Date | Thu, 27 Oct 2011 21:34:48 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] config: Add 'make kvmconfig' |
| |
On Thu, Oct 27, 2011 at 02:07:14PM +0200, Sasha Levin wrote: > This patch adds 'make kvmconfig' which allows to add KVM guest support > to a config file. > > This allows for easier testing of configurations under virtualized > environments. > > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Michal Marek <mmarek@suse.cz> > Cc: Pekka Enberg <penberg@cs.helsinki.fi> > Cc: linux-kbuild@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Suggested-by: Ingo Molnar <mingo@elte.hu> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
Two points about the implmentation that I do not like...
The kvmconfig is an x86 specific thing - so it does not belong in the scripts/kconfig/Makefile
The *config namespace is general config targets.
Suggestion: Move the implmentation to arch/x86/Makefile and name the target something that does not match the *config pattern.
Suggestion:
make kvmbootable
To tell that this convert the current config to a kvmbootable config.
And then add the target to the x86 specific help too.
Sam
| |