Messages in this thread | | | Date | Thu, 27 Oct 2011 14:48:03 -0400 | From | Mark Lord <> | Subject | Re: asix usb network driver: nfg |
| |
On 11-10-26 10:17 PM, David Miller wrote: > From: Mark Lord <kernel@teksavvy.com> > Date: Wed, 26 Oct 2011 21:23:15 -0400 > >> Any strong advance objections to replacing the in-kernel version >> with a (fixed) vendor open source version? > > It need to meet the coding etc. standards for inclusion, last > time I looked at it their driver indeed need a bit of cleaning up.
Yeah, okay -- I've got approval to spend some paid time on the effort, so I'll have a deeper look at things.
> It's a sad situation, they started with the upstream driver and > just hacked on it however they pleased in their private copy. > So now we have this huge divergance and no effort on their part > to rectify things.
Will there be any issues with "Signed-Off-By" on this? It's all GPL, by License, but we don't necessarily know who make what changes to their driver since they forked it. I don't think that matters much, but then what I think doesn't matter much either. :)
But it is the only one of the two that's close to working (and does work when DEBUG messages are enabled -- a timing issue somewhere that I'll fix).
Thanks David.
| |