lkml.org 
[lkml]   [2011]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] drivers: pinctrl: add a pin_base for sparse gpio-ranges
Chanho Park wrote at Wednesday, October 26, 2011 3:39 AM:
> Stephen Warren wrote at Wednesday, October 26, 2011 3:21 PM:
> > Chanho Park wrote at Tuesday, October 25, 2011 10:22 PM:
> > > This patch enables mapping a base offset of gpio ranges with
> > > a pin offset even if does'nt matched. A base of pinctrl_gpio_range
> > > means a base offset of gpio. However, we cannot convert gpio to pin
> > > number for sparse gpio ranges just only using a gpio base offset.
> > > We can convert a gpio to real pin number(even if not matched) using
> > > a new pin_base which means a base pin offset of requested gpio range.
> > ...
> > > diff --git a/include/linux/pinctrl/pinctrl.h
> > b/include/linux/pinctrl/pinctrl.h
> > > index 90dd28b..7768e44 100644
> > > --- a/include/linux/pinctrl/pinctrl.h
> > > +++ b/include/linux/pinctrl/pinctrl.h
> > > @@ -127,6 +127,7 @@ struct pinctrl_pin_desc {
> > > * @name: a name for the chip in this range
> > > * @id: an ID number for the chip in this range
> > > * @base: base offset of the GPIO range
> > > + * @pin_base: base pin offset of the GPIO range
> >
> > This may be bike-shedding, but I'd tend to call this "gpio_base", since
> > it's the first "gpio" number of this range, not the first "pin" number
> > ("pins" are used in the pinctrl subsystem, but "gpios" by the GPIO
> > Subsystem)
>
> A "base" means first "gpio" number of the range.
> And a "pin_base" means first "pin" number.
> Do you want to replace the "base" to the "gpio_base"?

Ah OK. I guess I misunderstood this slightly, since "base" was both a
pin and GPIO number before, or something like that.

Anyway, I certainly see value in s/base/gpio_base/ to make this all
explicit. Hopefully that doesn't cause the patch to grow too big and
churn the code too much.

--
nvpublic



\
 
 \ /
  Last update: 2011-10-27 18:15    [W:0.045 / U:1.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site