Messages in this thread | | | Date | Tue, 25 Oct 2011 23:47:10 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] APICID: Avoid false sharing on the read mostly x86_cpu_to_apicid |
| |
On Wed, 26 Oct 2011, Eial Czerwacki wrote:
> >> Signed-off-by: Eial Czerwacki<eial@scalemp.com> > >> Signed-off-by: Shai Fultheim<shai@scalemp.com> > >> Author: Ravikiran Thirumalai<kiran@scalex86.org> > > > > If the author isn't you, then the patch should start with a single line > > that says "From: name <email>" of the author followed by a blank line. > > It's also strange that the author doesn't have a sign-off line. > > > > > the author is mentioned after the last sign-off. >
That's not the way it's done, as I said, the patch needs to start with a single line like this:
From: Ravikiran Thirumalai <kiran@scalex86.org>
...
and if that person signed it off, then it needs to appear as
Signed-off-by: ...
as the first one in the chain. Please see part 15 of section 1 of Documentation/SubmittingPatches.
| |