Messages in this thread | | | Date | Wed, 26 Oct 2011 08:20:11 +0200 | From | Eial Czerwacki <> | Subject | Re: [PATCH] AMD: modify cpu probe from APICID to initial APICID |
| |
On 10/25/2011 11:51 PM, Yinghai Lu wrote: > On Tue, Oct 25, 2011 at 4:49 AM, Eial Czerwacki<eial@scalemp.com> wrote: >> Make AMD probe processors using APICID rather than the initial APICID. >> >> >> Signed-off-by: Eial Czerwacki<eial@scalemp.com> >> Signed-off-by: Shai Fultheim<shai@scalemp.com> >> --- >> >> --- a/arch/x86/kernel/cpu/amd.c 2011-09-14 05:58:19.542910736 -0700 >> +++ b/arch/x86/kernel/cpu/amd.c 2011-09-14 06:01:41.493209624 -0700 >> @@ -299,9 +299,9 @@ static void __cpuinit amd_detect_cmp(str >> >> bits = c->x86_coreid_bits; >> /* Low order bits define the core id (index of core in socket) */ >> - c->cpu_core_id = c->initial_apicid& ((1<< bits)-1); >> + c->cpu_core_id = c->apicid& ((1<< bits)-1); >> /* Convert the initial APIC ID into the socket ID */ >> - c->phys_proc_id = c->initial_apicid>> bits; >> + c->phys_proc_id = c->apicid>> bits; >> /* use socket ID also for last level cache */ >> per_cpu(cpu_llc_id, cpu) = c->phys_proc_id; >> /* fixup topology information on multi-node processors */ >> > > No, that is not right. > > We have to initial apicid to get socket/core mapping. > > BTW, your mail client has some problem with formatting. > > Thanks > > Yinghai > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
ok, I'll review the patch again.
is the format ok now?
Thanks,
Eial.
| |