Messages in this thread | | | Date | Wed, 26 Oct 2011 16:08:03 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] checkpatch: improve error message for p1-check |
| |
On Wed, 26 Oct 2011, Joe Perches wrote:
> > > The old error message was not precise. State now explicitly that the > > > prefix exists as a file/directory. Also change the conclusion ("appears > > > to be") into an instruction ("make sure"). > > Why can't we suppress this warning unless both prefixes appear as files or > > directories in the cwd? ('a' and 'b' if using git format-patch) > > I sent a suggested patch that checked $root/$patched_file > https://lkml.org/lkml/2011/10/19/257 >
So we need a combination of the two approaches then, it makes sense to only emit the warning if the patched file exists in both prefixes.
| |