lkml.org 
[lkml]   [2011]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv4 4/6] input/cma3000_d0x: Add CMA3000 spi support
On 10/25/11 08:24, Ricardo Ribalda Delgado wrote:
> Hello Grant
>
> Thanks for your comments. I am fixing the --- problem in all the patches.
>
>>
>> Mark Brown had posted a generic indirect register read/write library
>> that I believe is getting merged. Maybe this driver should be using
>> it?
>
> It is not on linux-next, and also it cannot be used directly, in order
> to read you have to do set reg= (reg << 2) | 2; And AFAIK it is not
> supported by the regmap
My gut feeling is it would easy enough to add if it can't currently
be done. Mark?

Gains here are leveraging the bus abstractions from there. There aren't
enough registers to gain from caching etc.
>
>>
>> Drop the .bus line. The core code does this bit for you.
>
> Done
>
>>> +module_init(cma3000_spi_init);
>>> +module_exit(cma3000_spi_exit);
>>
>> move module_init() directly below the function it registers.
>
> Also done, but I believe the other is more elegant :)
>>
>>> +
>>> +MODULE_DESCRIPTION("CMA3000-D0x Accelerometer SPI Driver");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_AUTHOR("Ricardo Ribalda <ricardo.ribalda@gmail.com>");
>>> --
>>> 1.7.7
>>>
>>
>
>
>



\
 
 \ /
  Last update: 2011-10-25 10:35    [from the cache]
©2003-2011 Jasper Spaans