lkml.org 
[lkml]   [2011]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/13] ida: make ida_simple_get/put() IRQ safe
    Date
    It's often convenient to be able to release resource from IRQ context.
    Make ida_simple_*() use irqsave/restore spin ops so that they are IRQ
    safe.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    ---
    lib/idr.c | 11 +++++++----
    1 files changed, 7 insertions(+), 4 deletions(-)

    diff --git a/lib/idr.c b/lib/idr.c
    index db040ce..dabdf79 100644
    --- a/lib/idr.c
    +++ b/lib/idr.c
    @@ -944,6 +944,7 @@ int ida_simple_get(struct ida *ida, unsigned int start, unsigned int end,
    {
    int ret, id;
    unsigned int max;
    + unsigned long flags;

    BUG_ON((int)start < 0);
    BUG_ON((int)end < 0);
    @@ -959,7 +960,7 @@ again:
    if (!ida_pre_get(ida, gfp_mask))
    return -ENOMEM;

    - spin_lock(&simple_ida_lock);
    + spin_lock_irqsave(&simple_ida_lock, flags);
    ret = ida_get_new_above(ida, start, &id);
    if (!ret) {
    if (id > max) {
    @@ -969,7 +970,7 @@ again:
    ret = id;
    }
    }
    - spin_unlock(&simple_ida_lock);
    + spin_unlock_irqrestore(&simple_ida_lock, flags);

    if (unlikely(ret == -EAGAIN))
    goto again;
    @@ -985,10 +986,12 @@ EXPORT_SYMBOL(ida_simple_get);
    */
    void ida_simple_remove(struct ida *ida, unsigned int id)
    {
    + unsigned long flags;
    +
    BUG_ON((int)id < 0);
    - spin_lock(&simple_ida_lock);
    + spin_lock_irqsave(&simple_ida_lock, flags);
    ida_remove(ida, id);
    - spin_unlock(&simple_ida_lock);
    + spin_unlock_irqrestore(&simple_ida_lock, flags);
    }
    EXPORT_SYMBOL(ida_simple_remove);

    --
    1.7.3.1


    \
     
     \ /
      Last update: 2011-10-26 03:51    [W:4.471 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site