lkml.org 
[lkml]   [2011]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC V2 5/5] kvm guest : pv-ticketlocks support for linux guests running on KVM hypervisor
    On 10/23/2011 12:07 PM, Raghavendra K T wrote:
    > This patch extends Linux guests running on KVM hypervisor to support
    > pv-ticketlocks. Very early during bootup, paravirtualied KVM guest detects if
    > the hypervisor has required feature (KVM_FEATURE_WAIT_FOR_KICK) to support
    > pv-ticketlocks. If so, support for pv-ticketlocks is registered via pv_lock_ops.
    >
    > Signed-off-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
    > Signed-off-by: Suzuki Poulose <suzuki@in.ibm.com>
    > Signed-off-by: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
    > ---
    > diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h
    > index 2874c19..c7f34b7 100644
    > --- a/arch/x86/include/asm/kvm_para.h
    > +++ b/arch/x86/include/asm/kvm_para.h
    > @@ -195,10 +195,18 @@ void kvm_async_pf_task_wait(u32 token);
    > void kvm_async_pf_task_wake(u32 token);
    > u32 kvm_read_and_reset_pf_reason(void);
    > extern void kvm_disable_steal_time(void);
    > -#else
    > +
    > +#ifdef CONFIG_PARAVIRT_SPINLOCKS
    > +void __init kvm_guest_early_init(void);
    > +#else /* CONFIG_PARAVIRT_SPINLOCKS */
    > +#define kvm_guest_early_init() do { } while (0)
    > +#endif /* CONFIG_PARAVIRT_SPINLOCKS */
    > +
    > +#else /* CONFIG_KVM_GUEST */
    > #define kvm_guest_init() do { } while (0)
    > #define kvm_async_pf_task_wait(T) do {} while(0)
    > #define kvm_async_pf_task_wake(T) do {} while(0)
    > +#define kvm_guest_early_init() do { } while (0)
    > static inline u32 kvm_read_and_reset_pf_reason(void)
    > {
    > return 0;
    > diff --git a/arch/x86/kernel/head32.c b/arch/x86/kernel/head32.c
    > index 3bb0850..fb25bca 100644
    > --- a/arch/x86/kernel/head32.c
    > +++ b/arch/x86/kernel/head32.c
    > @@ -9,6 +9,7 @@
    > #include <linux/start_kernel.h>
    > #include <linux/mm.h>
    > #include <linux/memblock.h>
    > +#include <linux/kvm_para.h>
    >
    > #include <asm/setup.h>
    > #include <asm/sections.h>
    > @@ -59,6 +60,8 @@ void __init i386_start_kernel(void)
    > break;
    > }
    >
    > + kvm_guest_early_init();
    > +
    > /*
    > * At this point everything still needed from the boot loader
    > * or BIOS or kernel text should be early reserved or marked not
    > diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
    > index 5655c22..cabf8ec 100644
    > --- a/arch/x86/kernel/head64.c
    > +++ b/arch/x86/kernel/head64.c
    > @@ -13,6 +13,7 @@
    > #include <linux/start_kernel.h>
    > #include <linux/io.h>
    > #include <linux/memblock.h>
    > +#include <linux/kvm_para.h>
    >
    > #include <asm/processor.h>
    > #include <asm/proto.h>
    > @@ -115,6 +116,8 @@ void __init x86_64_start_reservations(char *real_mode_data)
    >
    > reserve_ebda_region();
    >
    > + kvm_guest_early_init();
    > +
    > /*
    > * At this point everything still needed from the boot loader
    > * or BIOS or kernel text should be early reserved or marked not
    > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
    > index a9c2116..f4f341f 100644
    > --- a/arch/x86/kernel/kvm.c
    > +++ b/arch/x86/kernel/kvm.c
    > @@ -39,6 +39,16 @@
    > #include <asm/desc.h>
    > #include <asm/tlbflush.h>
    >
    > +#ifdef CONFIG_PARAVIRT_SPINLOCKS
    > +
    > +#ifdef CONFIG_KVM_DEBUG_FS
    > +
    > +#include <linux/debugfs.h>
    > +
    > +#endif /* CONFIG_KVM_DEBUG_FS */
    > +
    > +#endif /* CONFIG_PARAVIRT_SPINLOCKS */

    This is a big mess. Is there any problem with including linux/debugfs.h
    unconditionally? Or at least using "#if
    defined(CONFIG_PARAVIRT_SPINLOCKS) && defined(CONFIG_KVM_DEBUG_FS)"?

    J


    \
     
     \ /
      Last update: 2011-10-26 03:11    [W:0.026 / U:31.608 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site