lkml.org 
[lkml]   [2011]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/5]thp: improve the error code path
Hello,

On Tue, Oct 25, 2011 at 10:58:41AM +0800, Shaohua Li wrote:
> +#ifdef CONFIG_SYSFS
> + sysfs_remove_group(hugepage_kobj, &khugepaged_attr_group);
> +remove_hp_group:
> + sysfs_remove_group(hugepage_kobj, &hugepage_attr_group);
> +delete_obj:
> + kobject_put(hugepage_kobj);
> out:
> +#endif

Adding an ifdef is making the code worse, the whole point of having
these functions become noops at build time is to avoid having to add
ifdefs in the callers.


\
 
 \ /
  Last update: 2011-10-25 13:47    [W:0.060 / U:1.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site