Messages in this thread | | | Date | Tue, 25 Oct 2011 13:44:06 +0200 | From | Andrea Arcangeli <> | Subject | Re: [patch 1/5]thp: improve the error code path |
| |
Hello,
On Tue, Oct 25, 2011 at 10:58:41AM +0800, Shaohua Li wrote: > +#ifdef CONFIG_SYSFS > + sysfs_remove_group(hugepage_kobj, &khugepaged_attr_group); > +remove_hp_group: > + sysfs_remove_group(hugepage_kobj, &hugepage_attr_group); > +delete_obj: > + kobject_put(hugepage_kobj); > out: > +#endif
Adding an ifdef is making the code worse, the whole point of having these functions become noops at build time is to avoid having to add ifdefs in the callers.
| |